Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mssql): Alias env vars #925

Merged
merged 2 commits into from
May 26, 2023
Merged

chore(mssql): Alias env vars #925

merged 2 commits into from
May 26, 2023

Conversation

rthorn-nr
Copy link
Contributor

The following backwards-compatible aliases are added:

  • NR_CLI_DB_HOSTNAME -> NEW_RELIC_MSSQL_DB_HOSTNAME
  • NR_CLI_DB_PORT -> NEW_RELIC_MSSQL_DB_PORT
  • NR_CLI_DB_USERNAME -> NEW_RELIC_MSSQL_DB_USERNAME
  • NR_CLI_DB_PASSWORD -> NEW_RELIC_MSSQL_DB_PASSWORD
  • NR_CLI_SQL_USERNAME -> NEW_RELIC_MSSQL_SQL_USERNAME
  • NR_CLI_SQL_PASSWORD -> NEW_RELIC_MSSQL_SQL_PASSWORD
  • NR_CLI_ENABLE_BUFFER_METRICS -> NEW_RELIC_MSSQL_ENABLE_BUFFER_METRICS
  • NR_CLI_ENABLE_RESERVE_METRICS -> NEW_RELIC_MSSQL_ENABLE_RESERVE_METRICS

@rthorn-nr rthorn-nr requested review from Julien4218 and NRhzhao May 25, 2023 23:19
Copy link
Contributor

@Julien4218 Julien4218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small rename on local var, also for some reason the test failed.

@rthorn-nr rthorn-nr requested a review from Julien4218 May 26, 2023 16:01
Copy link
Contributor

@Julien4218 Julien4218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@rthorn-nr rthorn-nr merged commit 681a4f9 into main May 26, 2023
@rthorn-nr rthorn-nr deleted the chore/envvar-alias/mssql branch May 26, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants