Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests with OHI validation timeout to separate workflow #851

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

rthorn-nr
Copy link
Contributor

Creates a separate workflow (ohi-validation-timeout.yml) for the OHI tests in the nonregression workflow which are failing due to a validation timeout and filters those same tests out of the nonregression workflow:

const outputTestFilesMap = testDefinitions
  .filter((testDefinitionFile) => !isOHIValidationTimeout(testDefinitionFile))

For any other tests that need to be added to the workflow, add the path to the test (starting from the project root) to the array in .github/workflows/scripts/ohiValidationTimeout.js.

Other changes are due to autoformatting

@rthorn-nr
Copy link
Contributor Author

rthorn-nr commented Jan 10, 2023

Nonregression workflow run after filtering: https://github.com/newrelic/open-install-library/actions/runs/3885849009

OHI validation workflow run: https://github.com/newrelic/open-install-library/actions/runs/3885849012

The OHI validation workflow is set to be triggered only on workflow dispatch

@rthorn-nr
Copy link
Contributor Author

For future readers, this work will be removed once the validation timeout issue is resolved.

In the meantime, note that not all tests in the OHI validation workflow will fail every time (due to the nature of the validation timeout issue), but any OHI nonregression test that fails due to validation timeout at least once going forward should be added to the array in .github/workflows/scripts/ohiValidationTimeout.js.

Copy link
Contributor

@Julien4218 Julien4218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@rthorn-nr rthorn-nr merged commit 52d4486 into main Jan 10, 2023
@rthorn-nr rthorn-nr deleted the rt/ohi-validation-timeout-workflow branch January 10, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants