Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smoke/mysql-rhel #849

Merged
merged 2 commits into from
Jan 7, 2023
Merged

Fix smoke/mysql-rhel #849

merged 2 commits into from
Jan 7, 2023

Conversation

rthorn-nr
Copy link
Contributor

One of our smoke tests smoke/mysql-rhel.json has been failing consistently when downloading the mysql community release rpm file, either with a read timeout or a null error 'NoneType' object is not callable.

Using get_url instead of yum for the download uncovered a 403 when trying to download the file. Tried again with wget, and the issue was resolved.

Other changes:

  • become: yes -> true (to resolve linting warnings)
  • increased lock timeout for yum rpm install

Copy link
Contributor

@Julien4218 Julien4218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rthorn-nr this looks good, however I'm not seeing the impacted E2E tests running as part of this PR. I believe they need either a modification in the recipe file, or the test file. Could you do one of those so that we can see if the tests are passing with this change?

@rthorn-nr rthorn-nr requested a review from Julien4218 January 6, 2023 23:46
Copy link
Contributor

@Julien4218 Julien4218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @rthorn-nr

@rthorn-nr rthorn-nr merged commit c6a12bd into main Jan 7, 2023
@rthorn-nr rthorn-nr deleted the rt/fix-rhel-mysql-deploy-task branch January 7, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants