Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(debian): add redis debian recipe #140

Merged
merged 4 commits into from
Jan 22, 2021
Merged

feat(debian): add redis debian recipe #140

merged 4 commits into from
Jan 22, 2021

Conversation

JakubKotkowiak
Copy link
Contributor

No description provided.

@jbeveland27 jbeveland27 self-requested a review January 21, 2021 23:08
Copy link
Contributor

@jbeveland27 jbeveland27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JakubKotkowiak - Question: Can the redis.conf template be copied over after redis is installed from apt? As in, is a sample config downloaded that we can just use or are there edits in that file? I worry having the config here in the repo might make it go stale over time as installing redis with the package manager will always pull the latest version.

@jbeveland27 jbeveland27 self-requested a review January 22, 2021 04:01
Copy link
Contributor

@jbeveland27 jbeveland27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jbeveland27 jbeveland27 merged commit a87c0d8 into main Jan 22, 2021
@jbeveland27 jbeveland27 deleted the redisDebian branch January 22, 2021 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants