Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NR-298654: Adding ubuntu 24 support for logs recipe #1098

Merged
merged 13 commits into from
Aug 12, 2024
Merged

NR-298654: Adding ubuntu 24 support for logs recipe #1098

merged 13 commits into from
Aug 12, 2024

Conversation

nr-rkallempudi
Copy link
Contributor

No description provided.

@nr-rkallempudi nr-rkallempudi self-assigned this Jul 24, 2024
@nr-rkallempudi nr-rkallempudi marked this pull request as ready for review July 24, 2024 16:43
@nr-rkallempudi
Copy link
Contributor Author

Extending SuperAgent and Infra agent support for logs on following distributions:

  1. Ubuntu 24.04
  2. Suse 15.*

danybmx
danybmx requested changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@danybmx danybmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nr-rkallempudi thanks a lot for the contribution! Although I left some comments this is so nice!

recipes/newrelic/infrastructure/logs/linux-logs.yml Outdated Show resolved Hide resolved
recipes/newrelic/infrastructure/super-agent/logs/linux-logs.yml Outdated Show resolved Hide resolved
recipes/newrelic/infrastructure/super-agent/logs/linux-logs.yml Outdated Show resolved Hide resolved
danybmx
danybmx previously approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@danybmx danybmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@nr-rkallempudi
Copy link
Contributor Author

Following are the effective changes done as part of the PR:

  1. Extended Logs support for Ubuntu 24.04
  2. Extended Logs support for Suse 15.5
  3. Removed installTargets of Suse 15.5 for aarch64 as Fluent Bit support is not available
  4. Updated test cases. Tests are not validated on local host. Requested Virtuous team to run the tests before approving the PR

@nr-rkallempudi nr-rkallempudi changed the title NR-292615: Adding ubuntu 24 support for logs recipe NR-298654: Adding ubuntu 24 support for logs recipe Aug 1, 2024
danybmx
danybmx previously approved these changes Aug 5, 2024
View reviewed changes
@Nandu-pns
Copy link
Contributor

Hi @nr-rkallempudi - Changes looks good to us. I was able to test them out and could see logs-integration is being installed successfully on the latest host versions.

Nandu-pns
Nandu-pns previously approved these changes Aug 6, 2024
View reviewed changes
@nr-rkallempudi
Copy link
Contributor Author

nr-rkallempudi commented Aug 10, 2024 •
edited
Loading

Done validations on Suse 15.4 and Suse 15.5 and identified that Fluent bit is not installing on all AMIs of SLES 15.4 and 15.5.

Test cases are modified to validate integrations AMIs mentioned on fluentbit package: https://github.com/newrelic/fluent-bit-package/blob/main/versions/sles_15.5.yml

Created Jira task to track this one on priority.
https://new-relic.atlassian.net/browse/NR-301797

Screenshots of successful installation of fluent bit on EC2 hosts:
Screenshot 2024-08-10 at 2 45 23 PM

Screenshot 2024-08-10 at 2 46 02 PM

Avinash-Sanpala
Avinash-Sanpala approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@Avinash-Sanpala Avinash-Sanpala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Avinash-Sanpala Avinash-Sanpala merged commit 039776f into main Aug 12, 2024
21 of 22 checks passed
@Avinash-Sanpala Avinash-Sanpala deleted the NR-292615 branch August 12, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avinash-Sanpala Avinash-Sanpala Avinash-Sanpala approved these changes

@Nandu-pns Nandu-pns Nandu-pns left review comments

@danybmx danybmx danybmx left review comments

@NSSPKrishna NSSPKrishna Awaiting requested review from NSSPKrishna

Assignees

@nr-rkallempudi nr-rkallempudi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nr-rkallempudi @Nandu-pns @danybmx @Avinash-Sanpala