Skip to content

Commit

Permalink
Merge pull request #466 from newrelic/slo-no-incidents-msg
Browse files Browse the repository at this point in the history
fix: display message when alerting service level has no incidents
  • Loading branch information
amit-y authored Nov 15, 2024
2 parents 294360b + 41768ba commit e852165
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/components/signal-detail-sidebar/incidents.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,14 @@ const Incidents = ({ type, data, timeWindow }) => {
</HeadingText>
<div className="alert-incidents">
{bannerMessage && <SectionMessage description={bannerMessage} />}
{data?.type === 'SERVICE_LEVEL' &&
data?.alertSeverity !== 'NOT_ALERTING' &&
!incidentsList?.length ? (
<SectionMessage
type={SectionMessage.TYPE.WARNING}
description={UI_CONTENT.SIGNAL.DETAILS.ALERTING_SL_NO_INCIDENT}
/>
) : null}
{incidentsList.reduce(
(
acc,
Expand Down
2 changes: 2 additions & 0 deletions src/constants/ui-content.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,8 @@ export const UI_CONTENT = {
NO_RECENT_INCIDENTS: 'No open incidents to display.',
LATEST_RECENT_INCIDENT:
'No open incidents. Showing the most recent incident.',
ALERTING_SL_NO_INCIDENT:
"This Service Level is in an unhealthy state, however we can't find any correlated incidents. It is likely that the Service Level is out of compliance - to investigate further, please open the entity view (linked above).",
},
TOOLTIP: {
WORKLOAD_UNKNOWN: 'The status of this workload is unknown',
Expand Down

0 comments on commit e852165

Please sign in to comment.