Skip to content

Commit

Permalink
Merge pull request #111 from newrelic/eip-intl-kb-fix
Browse files Browse the repository at this point in the history
fix: add check for composing on save in edit-in-place
  • Loading branch information
amit-y authored Oct 29, 2024
2 parents 1d1acd2 + cd9b6b0 commit 5852bc2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- EditInPlace - prevents save when in composition session

## [1.23.4] - 2024-09-20

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion src/components/edit-in-place/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ const EditInPlace = forwardRef(
const keyDownHandler = useCallback((evt) => {
const { ctrlKey, metaKey, keyCode } = evt;
// save on enter
if (keyCode === 13) {
if (!evt?.nativeEvent?.isComposing && keyCode === 13) {
evt.preventDefault();
editableRef.current.blur();
}
Expand Down

0 comments on commit 5852bc2

Please sign in to comment.