Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix vulnerabilities #288

Merged
merged 2 commits into from
Jul 31, 2019
Merged

chore: fix vulnerabilities #288

merged 2 commits into from
Jul 31, 2019

Conversation

aorinevo
Copy link
Contributor

@aorinevo aorinevo commented Jul 1, 2019 •
edited
Loading

CHANGE LOG

  • ran npm dedupe && npm audit --fix
  • ran npm update handlebars --depth 4 && npm dedupe

INTERNAL LINKS

NOTES

@aorinevo aorinevo changed the title chore: fix vulnerabilities part 1. chore: fix vulnerabilities Jul 1, 2019
@aorinevo
Copy link
Contributor Author

aorinevo commented Jul 8, 2019

@psvet, @NatalieWolfe, @lykkin: Can you review and let me know your thoughts?

@aorinevo aorinevo mentioned this pull request Jul 8, 2019
Merged
@michaelgoin
Copy link
Member

Hey, thanks for the PR. We'll take a look as we can.

Just a heads up: Natalie (@NatalieWolfe) and Peter(@psvet) are no longer at New Relic, so I wouldn't keep pinging them.

Thanks!

Michael

@aorinevo
Copy link
Contributor Author

aorinevo commented Jul 8, 2019

Sorry @michaelgoin, will not tag them going forward.

Apologies again :)

lykkin
lykkin approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@lykkin lykkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aorinevo Thanks for fixing this. I'll open up a PR to merge this into our internal integration stream - this should go out in the next couple of releases.

@astormnewrelic astormnewrelic merged commit d284430 into newrelic:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lykkin lykkin lykkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aorinevo @michaelgoin @lykkin @astormnewrelic