ci: disable running CI for releases #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
changed the title
jordigh
force-pushed
the
disable-ci-for-releases
branch
from
cf7bda4 to
0ac9131
Compare
Codecov Report
@@ Coverage Diff @@
## main #1671 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 200 200
Lines 39180 39180
Branches 24 24
=======================================
Hits 37955 37955
Misses 1225 1225
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jordigh
force-pushed
the
disable-ci-for-releases
branch
from
0ac9131 to
088a8af
Compare
jmartin4563
suggested changes
Jun 20, 2023
1) First, disable running on pushes. This is because pushes don't have context when they come from a pull request. In particular, pushes don't have the branch name the pull request came from. 2) Then, disable running if the branch name starts with release. 3) In the same condition check, enable runs only for branches that are closed via a merge. We don't want to trigger CI for a PR that is closed because we decided to abandon the idea. fix: remove unnecessary conditional
jordigh
force-pushed
the
disable-ci-for-releases
branch
from
20e20a4 to
1e87593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes introduced in this pull request.
What problem does it solve? What is the context of this change?
There are a few parts to this:
First, disable running on pushes. This is because pushes don't have context when they come from a pull request. In particular, pushes don't have the branch name the pull request came from.
At the same time, enable running on
synchronizeandcloseactions onpull_requestevents. This will ensure that when a PR gets updated or merged, we'll see a CI run. This changes the default actions of only running onopened,synchronize, orreopened.Then, disable running if the branch name starts with release.
In the same condition check, enable runs only for branches that are closed via a merge. We don't want to trigger CI for a PR that is closed because we decided to abandon the idea.
How to Test
Scenarios in my test repo, when running PRs from a fork:
--majorversioned re-run: https://github.com/jordigh/node-newrelic-testing-gha/actions/runs/5269064911/jobs/9526651087#step:7:103--minorversioned run on main: https://github.com/jordigh/node-newrelic-testing-gha/actions/runs/5269330927/jobs/9527313867#step:2:373 https://github.com/jordigh/node-newrelic-testing-gha/actions/runs/5269330927/jobs/9527313867#step:7:99Note: this test repo has no secrets, which explains the CI failures.
Related Issues