Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): log execArgs at the debug level #1654

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

jordigh
Copy link
Contributor

@jordigh jordigh commented May 31, 2023

Closes #1651

@jordigh jordigh force-pushed the fix-args-logging branch from 43c7d99 to c546c45 Compare May 31, 2023 14:46
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #1654 (66ffbd5) into main (b693ba0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1654   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files         200      201    +1     
  Lines       39078    39145   +67     
  Branches       24       24           
=======================================
+ Hits        37781    37848   +67     
  Misses       1297     1297           
Flag Coverage Δ
esm-unit-tests-14.x 47.80% <ø> (ø)
esm-unit-tests-16.x ?
esm-unit-tests-18.x 92.11% <ø> (ø)
integration-tests-14.x 78.98% <100.00%> (+<0.01%) ⬆️
integration-tests-16.x 79.08% <100.00%> (+0.01%) ⬆️
integration-tests-18.x 79.07% <100.00%> (+<0.01%) ⬆️
unit-tests-14.x 91.31% <100.00%> (+<0.01%) ⬆️
unit-tests-16.x 91.36% <100.00%> (+<0.01%) ⬆️
unit-tests-18.x 91.34% <100.00%> (+<0.01%) ⬆️
versioned-tests-14.x 75.60% <ø> (ø)
versioned-tests-16.x 76.94% <100.00%> (+0.04%) ⬆️
versioned-tests-18.x 76.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
index.js 80.10% <100.00%> (+0.53%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bizob2828 bizob2828 self-assigned this May 31, 2023
bizob2828
bizob2828 previously approved these changes May 31, 2023
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thought for an additional test but overall looks good

test/integration/logger.tap.js Outdated Show resolved Hide resolved
This now tests both the -r and the --experimental-loader arg
@jordigh jordigh merged commit c85c006 into newrelic:main Jun 1, 2023
@jordigh jordigh deleted the fix-args-logging branch June 1, 2023 17:12
@github-actions github-actions bot mentioned this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

process.execArgv isn't getting logged in debug-level agents logs
2 participants