STTP 2 & 3 Scala HTTP Client Instrumentation #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instrumentation to capture send requests for three sttp backends, HttpURLConnectionBackend, Http4sBackend & AkkaHttpBackend
GDownes
changed the title
twcrone
approved these changes
Aug 20, 2021
|
Ran unit tests locally for these instrumentations and passed. Unit tests Scala compile still flaky for larger project execution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds partial instrumentation for STTP a Scala HTTP client.
https://sttp.softwaremill.com/en/latest/
This PR targets STTP version 2.x & 3.x introducing instrumentation for three STTP backends:
HttpURLConnectionBackend
AkkaHttpBackend
Http4sBackend
The full list of supported backends:
https://sttp.softwaremill.com/en/latest/backends/summary.html
Related Github Issue
#315
Testing
Introspector based unit tests were created to showcase the usage of the STTP client before and after instrumentation.
After instrumentation more segments are created and captured including HTTP specific details.
Verify instrumentation tasks ran successfully
Sample application created to use instrumentation and review in New Relic One:
https://github.com/GDownes/newrelic-sttp-instrumentation-usage
Checks
[X] Are your contributions backwards compatible with relevant frameworks and APIs? Yes, standalone instrumentation
[X] Does your code contain any breaking changes? No
[X] Does your code introduce any new dependencies? Yes, new dependencies to support instrumentation