Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support akka-http-core version 10.2.1 #88

Closed
jobicarter opened this issue Oct 19, 2020 · 1 comment
Closed

Support akka-http-core version 10.2.1 #88

jobicarter opened this issue Oct 19, 2020 · 1 comment

Comments

@jobicarter
Copy link

jobicarter commented Oct 19, 2020

Issue Overview

APM Java Agent documentation shows compatibility up to latest versions for auto instrumentation on akka-http-core, but it does not work for the latest versions. Java agent versions 6.0.0 and 6.1.0 were tested, and instrumentation tests were run for confirmation.

As of 10/7, the latest compatible (stable release) version of akka-http-core is 10.1.12 according to instrumentation module tests. I have tested this version and it does work.

Feature Description

Please update the agent for compatibility with akka-http-core 10.2.1, the latest version at this time.

Additional context

Refer to https://support.newrelic.com/tickets/430194 for additional discussion and context.

Priority

This will be necessary for continued use of the java agent with akka-http-core, but is not an emergency.
Custom / manual instrumentation may be used as a workaround.

Info

Here are the 10/7 instrumentation tests results.

Failure for 10.2.1:

Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.2.1

Full dump:

Task :buildSrc:compileJava UP-TO-DATE
Task :buildSrc:compileGroovy NO-SOURCE
Task :buildSrc:processResources NO-SOURCE
Task :buildSrc:classes UP-TO-DATE
Task :buildSrc:jar UP-TO-DATE
Task :buildSrc:assemble UP-TO-DATE
Task :buildSrc:compileTestJava NO-SOURCE
Task :buildSrc:compileTestGroovy NO-SOURCE
Task :buildSrc:processTestResources NO-SOURCE
Task :buildSrc:testClasses UP-TO-DATE
Task :buildSrc:test NO-SOURCE
Task :buildSrc:check UP-TO-DATE
Task :buildSrc:build UP-TO-DATE
Task :agent-bridge:requiresJava7
Task :agent-bridge:requiresJava8
Task :newrelic-api:requiresJava7
Task :newrelic-api:requiresJava8
Task :newrelic-api:compileJava UP-TO-DATE
Task :newrelic-weaver-api:requiresJava7
Task :newrelic-weaver-api:requiresJava8
Task :newrelic-weaver-api:compileJava UP-TO-DATE
Task :agent-bridge:compileJava UP-TO-DATE
Task :instrumentation:akka-http-cor.0.11:requiresJava7
Task :instrumentation:akka-http-core-10.0.11:requiresJava8
Task :instrumentation:akka-http-core-10.0.11:compileJava NO-SOURCE
Task :instrumentation:akka-http-core-10.0.11:compileScala UP-TO-DATE
Task :instrumentation:akka-http-core-10.0.11:processResources NO-SOURCE
Task :instrumentation:akka-http-core-10.0.11:classes UP-TO-DATE
Task :newrelic-weaver:requiresJava7
Task :newrelic-weaver:requiresJava8
Task :newrelic-weaver-scala-api:requiresJava7
Task :newrelic-weaver-scala-api:requiresJava8
Task :newrelic-weaver-scala-api:compileJava UP-TO-DATE
Task :newrelic-weaver:compileJava UP-TO-DATE
Task :instrumentation-build:compileJava UP-TO-DATE
Task :instrumentation-build:processResources NO-SOURCE
Task :instrumentation-build:classes UP-TO-DATE
Task :newrelic-weaver:processResources UP-TO-DATE
Task :newrelic-weaver:classes UP-TO-DATE
Task :newrelic-weaver:jar UP-TO-DATE
Task :newrelic-weaver-api:processResources NO-SOURCE
Task :newrelic-weaver-api:classes UP-TO-DATE
Task :newrelic-weaver-api:jar UP-TO-DATE
Task :newrelic-weaver-scala-api:processResources NO-SOURCE
Task :newrelic-weaver-scala-api:classes UP-TO-DATE
Task :newrelic-weaver-scala-api:jar UP-TO-DATE
Task :instrumentation-build:shadowJar UP-TO-DATE
Task :instrumentation:akka-http-core-10.0.11:writeCachedWeaveAttributes UP-TO-DATE
Task :instrumentation:akka-http-core-10.0.11:jar UP-TO-DATE
Task :instrumentation:akka-http-core-10.0.11:verifyInstrumentation UP-TO-DATE
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.2.0-M1
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.1.9
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.1.5
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.1.7
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.1.3
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.1.4
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.1.6
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.1.8
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.1.2
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.1.10
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.1.11
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.1.0-RC1
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.1.12
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.1.0-RC2
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.1.1
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.1.0
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.0.15
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.0.14
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.1.8
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.0.12
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.1.9
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.0.11
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.12_10.0.13
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.1.7
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.1.6
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.1.2
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.1.5
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.1.4
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.1.3
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.1.11
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.1.12
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.1.10
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.1.1
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.1.0-RC1
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.1.0
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.1.0-RC2
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.0.15
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.0.14
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.0.13
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.0.12
Task :instrumentation:akka-http-core-10.0.11:verifyPass_classpath
Task :instrumentation:akka-http-core-10.0.11:verifyPass_com.typesafe.akka_akka-http-core_2.11_10.0.11
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.2.0-RC2
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.2.1
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.2.0-RC1
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.0.9
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.2.0
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.0.8
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.0.6+7-e2ba6752
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.0.6
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.0.7
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.0.4
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.0.5
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.0.2
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.0.3
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.0.10
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.0.1
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.0.0-RC2
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.12_10.0.0
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_3.0.0-RC1
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.9-RC2
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.9
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.9-RC1
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.8
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.6
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.7
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.5
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.4
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.2-RC1
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.2-RC3
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.2-RC2
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.3
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.11.2
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.2
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.11.1
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.11
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4-ARTERY-M4
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4.10
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4-ARTERY-M2
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4-ARTERY-M3
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_2.4-ARTERY-M1
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_10.0.9
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_10.0.7
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_10.0.8
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_10.0.6+7-e2ba6752
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_10.0.6
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_10.0.5
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_10.0.4
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_10.0.3
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_10.0.2
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_10.0.1
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_10.0.10
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_10.0.0
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core_2.11_10.0.0-RC2
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.11_2.0.5
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.11_2.0.4
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.11_2.0.3
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.11_2.0.2
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.11_2.0.1
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.11_2.0-M2
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.11_2.0
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.11_2.0-M1
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.11_1.0
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.10_2.0.5
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.10_2.0.4
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.10_2.0.3
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.10_2.0.2
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.10_2.0.1
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.10_2.0-M2
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.10_2.0-M1
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.10_2.0
Task :instrumentation:akka-http-core-10.0.11:verifyFail_com.typesafe.akka_akka-http-core-experimental_2.10_1.0
BUILD SUCCESSFUL in 20s
138 actionable tasks: 124 executed, 14 up-to-date
@tspring
Copy link
Contributor

tspring commented Oct 20, 2020

@jobicarter Thanks for letting us know. Turns out it was a pretty simple fix. I pushed a PR here if you'd like to try it and let us know if it works for you.

tspring added a commit that referenced this issue Oct 23, 2020
Add instrumentation for Akka-http-core 10.2.0. Fixes #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants