Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review/test proposed Scala 2.13 instrumentation #143

Closed
jasonjkeller opened this issue Dec 7, 2020 · 1 comment
Closed

Review/test proposed Scala 2.13 instrumentation #143

jasonjkeller opened this issue Dec 7, 2020 · 1 comment
Assignees
@tspring
Milestone
Scala 2.13 Support

Comments

@jasonjkeller
Copy link
Contributor

This issue belongs to the Test Scala 2.13 PRs Epic

We have a community submitted PR for Scala 2.13 support: #109

We need to review the PR and validate that there are no performance or behavior regressions from our Scala 2.12 instrumentation.

We should also compare and contrast this instrumentation with modules created by FIT. How does their Scala 2.13 instrumentation compare? Does this instrumentation play nicely with other FIT instrumentation in the ecosystem (Netty, Akka, Play)? See #142
@jasonjkeller jasonjkeller mentioned this issue Dec 7, 2020
Closed
@kford-newrelic kford-newrelic added this to the Scala 2.13 Support milestone Dec 9, 2020
@tspring tspring self-assigned this Dec 9, 2020
@tspring
Copy link
Contributor

tspring commented Dec 9, 2020

Performance and functionality of both the scala-2.13 and combined scala and akka-http-core_2.13 work is inline with our existing 2.12. I'm going to call this work done and merge them to main

@tspring tspring closed this as completed Dec 9, 2020
jasonjkeller pushed a commit that referenced this issue Jun 4, 2024
@lspangler584
Merge pull request #143 from agents/lspangler-patch-1
adaf77e 
Update trace_context.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tspring tspring

Labels
None yet
Projects
Java Engineering Board
Archived in project
Milestone
Scala 2.13 Support
Development

No branches or pull requests
3 participants
@tspring @jasonjkeller @kford-newrelic