-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add organizationRevokeSharedAccount
and accountManagementCancelAccount
mutations
#1187
feat: add organizationRevokeSharedAccount
and accountManagementCancelAccount
mutations
#1187
Conversation
7888c00
to
f3630e1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
- Coverage 38.84% 38.40% -0.44%
==========================================
Files 86 96 +10
Lines 5612 4822 -790
==========================================
- Hits 2180 1852 -328
+ Misses 3266 2795 -471
- Partials 166 175 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
organizationRevokeSharedAccount
and accountManagementCancelAccount
mutations
Hi @iamsumit and @coderkakarrot, thank you for submitting these additions to the New Relic Go Client. While all of the changes you've made are exactly on par with what one is supposed to do via Tutone, we've noticed a few discrepancies with the generated code (upon trying this myself), in response to which I had to make a couple of other changes to your code - just wanted to share these with you for context. This note shall also be useful for maintainers of the New Relic Go Client to take note of.
Owing to the above, we've moved duplicated code of the Rest assured, the functions for the new mutations you've added one each in I shall proceed with merging this PR and releasing these changes; shall keep you guys posted if we find a way sometime to bring |
@iamsumit FYI: these changes have just been released with v2.41.0 of the New Relic Go Client 🎉 |
@pranav-new-relic Thank you, @pranav-new-relic for this. |
We need these mutations for the project we're implementing this so adding it as PR. Thanks!