feat(build): upgrade to Go v1.21 ✨ #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranav-new-relic
force-pushed
the
go1.21-upgrade
branch
from
b33e58f to
b340d37
Compare
|
pkg/testhelpers/helpers.go
Outdated
| rand.Seed(time.Now().UnixNano()) | ||
| // commented this line out, since this no longer works with go1.21 and needs no alternative, as seeding isn't needed | ||
| // rand.Seed(time.Now().UnixNano()) |
pranav-new-relic
force-pushed
the
go1.21-upgrade
branch
from
a5f9ed1 to
2cc3e22
Compare
sanderblue
approved these changes
Apr 30, 2024
pranav-new-relic
force-pushed
the
go1.21-upgrade
branch
from
3334b4b to
0373aff
Compare
NSSPKrishna
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps up the version of Golang used in dependencies and GitHub workflows to
go1.21Approach adapted from newrelic/newrelic-cli#1592 newrelic/terraform-provider-newrelic#2557
Question: Does this PR also need changes in
.golangci.ymlas made in newrelic/newrelic-cli#1592? @sanderblue