chore: gofmt all the things

.golangci.yml

@@ -31,9 +31,9 @@ linters-settings:
     include-go-root: false
     packages:
       - github.com/davecgh/go-spew/spew
-  # misspell:
-  #   ignore-words:
-  #     - newrelic
+  misspell:
+    ignore-words:
+      - newrelic
   lll:
     # max line length, lines longer will be reported. Default is 120.
     # '\t' is counted as 1 character by default, and can be changed with the tab-width option
@@ -51,12 +51,12 @@ linters:
   enable:
     - errcheck
     - gocyclo
-    # - gofmt
+    - gofmt
     - revive
     - gosimple
     - govet
     - ineffassign
-    # - misspell
+    - misspell
     - staticcheck
     - unconvert
     - unused

build/lint.mk

@@ -22,7 +22,7 @@ PROJECT_MODULE  ?= $(shell $(GO) list -m)
 
 GO_MOD_OUTDATED ?= go-mod-outdated
 
-lint: deps lint-commit golangci goimports outdated # spell-check gofmt
+lint: deps spell-check gofmt lint-commit golangci goimports outdated
 lint-fix: deps spell-check-fix gofmt-fix goimports
 
 #

internal/http/graphql.go

@@ -94,7 +94,8 @@ func (r *GraphQLErrorResponse) IsPaymentRequired(resp *http.Response) bool {
 // is deprecated.  We want to bubble that up, but not stop returning data
 //
 // Example deprecation message:
-//   This field is deprecated! Please use `relatedEntities` instead.
+//
+//	This field is deprecated! Please use `relatedEntities` instead.
 func (r *GraphQLErrorResponse) IsDeprecated() bool {
 	for _, err := range r.Errors {
 		if strings.HasPrefix(err.Message, "This field is deprecated!") {

newrelic/doc.go

@@ -3,13 +3,12 @@ Package newrelic is a convenience package that provides a programmatic API surfa
 area for interacting with all the New Relic One products encompassed by this project.
 Refer to each package's documentation to learn more about its capabilities.
 
-Authentication
+# Authentication
 
 You will need a valid Personal API to communicate with the backend New Relic
 APIs that this client communicates with.  See the API key documentation below
 for more information on how to locate this key:
 
 https://docs.newrelic.com/docs/apis/get-started/intro-apis/types-new-relic-api-keys
-
 */
 package newrelic

pkg/accountmanagement/accountmanagement_integration_test.go

@@ -3,8 +3,9 @@ package accountmanagement
 import (
 	"testing"
 
-	mock "github.com/newrelic/newrelic-client-go/v2/pkg/testhelpers"
 	"github.com/stretchr/testify/require"
+
+	mock "github.com/newrelic/newrelic-client-go/v2/pkg/testhelpers"
 )
 
 func TestIntegrationCreateAccount(t *testing.T) {

pkg/accounts/doc.go

@@ -2,13 +2,12 @@
 Package accounts provides a programmatic API for interacting with New Relic accounts.
 It can be used to retrieve details about all accounts the user is authorized to view.
 
-Authentication
+# Authentication
 
 You will need a valid Personal API key to communicate with the backend New Relic
 API that provides this functionality.  See the API key documentation below for
 more information on how to locate this key:
 
 https://docs.newrelic.com/docs/apis/get-started/intro-apis/types-new-relic-api-keys
-
 */
 package accounts

pkg/agentapplications/agentapplications_integration_test.go

@@ -6,9 +6,10 @@ package agentapplications
 import (
 	"testing"
 
+	"github.com/stretchr/testify/require"
+
 	"github.com/newrelic/newrelic-client-go/v2/pkg/common"
 	"github.com/newrelic/newrelic-client-go/v2/pkg/testhelpers"
-	"github.com/stretchr/testify/require"
 )
 
 // GUID for Dummy App in integration test account

pkg/alerts/doc.go

@@ -22,14 +22,13 @@ Alerts product.  It can be used for a variety of operations, including:
 
 - Associating one or more alert conditions with a policy
 
-Authentication
+# Authentication
 
 You will need a valid API key to communicate with the backend New Relic APIs
 that provide this functionality.  Use a Personal API key for authentication.
 See the API key documentation below for more information on how to locate this
 key:
 
 https://docs.newrelic.com/docs/apis/get-started/intro-apis/types-new-relic-api-keys
-
 */
 package alerts

pkg/alerts/nrql_conditions_integration_test.go

@@ -228,7 +228,7 @@ var (
 	}
 )
 
-//REST API integration test (deprecated)
+// REST API integration test (deprecated)
 func TestIntegrationNrqlConditions(t *testing.T) {
 	t.Parallel()
 

pkg/apiaccess/insights_keys_integration_test.go

@@ -73,7 +73,7 @@ func TestIntegrationAPIAccess_InsightsQueryKeys(t *testing.T) {
 	require.NotNil(t, deleteResult)
 }
 
-//nolint: unused
+// nolint: unused
 func newIntegrationTestClient(t *testing.T) APIAccess {
 	tc := mock.NewIntegrationTestConfig(t)
 

pkg/apiaccess/keys.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+
 	"github.com/newrelic/newrelic-client-go/v2/internal/http"
 )
 

pkg/apiaccess/keys_integration_test.go

@@ -4,11 +4,13 @@
 package apiaccess
 
 import (
-	mock "github.com/newrelic/newrelic-client-go/v2/pkg/testhelpers"
-	"github.com/stretchr/testify/require"
 	"regexp"
 	"strings"
 	"testing"
+
+	"github.com/stretchr/testify/require"
+
+	mock "github.com/newrelic/newrelic-client-go/v2/pkg/testhelpers"
 )
 
 func TestIntegrationAPIAccess_IngestKeys(t *testing.T) {

pkg/apm/doc.go

@@ -10,22 +10,21 @@ APM product.  It can be used for a variety of operations, including:
 
 - Creating, reading, and deleting APM labels
 
-Authentication
+# Authentication
 
 You will need a valid Personal API key to communicate with the backend New Relic
 APIs that provide this functionality. See the API key documentation below for
 more information on how to locate this key:
 
 https://docs.newrelic.com/docs/apis/get-started/intro-apis/types-new-relic-api-keys
 
-Labels
+# Labels
 
 New Relic One entity tags are currently the preferred method for organizing your
 New Relic resources.  Consider using entity tags via the `entities` package if
 you are just getting started.  More information about entity tags and APM labels
 can be found at the following URL:
 
 https://docs.newrelic.com/docs/new-relic-one/use-new-relic-one/core-concepts/tagging-use-tags-organize-group-what-you-monitor#labels
-
 */
 package apm

pkg/cloud/cloud_api_integration_test.go

@@ -8,8 +8,9 @@ import (
 	"strings"
 	"testing"
 
-	mock "github.com/newrelic/newrelic-client-go/v2/pkg/testhelpers"
 	"github.com/stretchr/testify/require"
+
+	mock "github.com/newrelic/newrelic-client-go/v2/pkg/testhelpers"
 )
 
 func TestCloudAccount_Basic(t *testing.T) {

pkg/cloud/cloud_api_unit_test.go

@@ -8,8 +8,9 @@ import (
 	"strconv"
 	"testing"
 
-	mock "github.com/newrelic/newrelic-client-go/v2/pkg/testhelpers"
 	"github.com/stretchr/testify/assert"
+
+	mock "github.com/newrelic/newrelic-client-go/v2/pkg/testhelpers"
 )
 
 var (

pkg/config/doc.go

@@ -2,13 +2,12 @@
 Package config provides a configuration surface area for configuring the underlying
 client.
 
-Authentication
+# Authentication
 
 You will need a valid Personal API key to communicate with the backend New Relic
 APIs that power the client. See the API key documentation below for more
 information on how to locate this key:
 
 https://docs.newrelic.com/docs/apis/get-started/intro-apis/types-new-relic-api-keys
-
 */
 package config

pkg/dashboards/doc.go

@@ -6,13 +6,12 @@ on working with these resources:
 
 https://docs.newrelic.com/docs/insights/insights-api/manage-dashboards/insights-dashboard-api
 
-Authentication
+# Authentication
 
 You will need a Personal API key to communicate with the backend New Relic API
 that provides this functionality. See the API key documentation below for
 more information on how to locate this key:
 
 https://docs.newrelic.com/docs/apis/get-started/intro-apis/types-new-relic-api-keys
-
 */
 package dashboards

pkg/edge/doc.go

@@ -3,13 +3,12 @@ Package edge provides a programmatic API for interacting with New Relic Edge wit
 infinite tracing. It can be used to enable New Relic Edge and retrieve relevant
 config parameters.
 
-Authentication
+# Authentication
 
 You will need a valid Personal API key to communicate with the backend New Relic
 API that provides this functionality.  See the API key documentation below for
 more information on how to locate this key:
 
 https://docs.newrelic.com/docs/apis/get-started/intro-apis/types-new-relic-api-keys
-
 */
 package edge

pkg/entities/doc.go

@@ -6,13 +6,12 @@ entities.  It can be used for a variety of operations, including:
 
 - Creating, reading, updating, and deleting New Relic One entity tags
 
-Authentication
+# Authentication
 
 You will need a valid Personal API key to communicate with the backend New Relic
 API that provides this functionality.  See the API key documentation below for
 more information on how to locate this key:
 
 https://docs.newrelic.com/docs/apis/get-started/intro-apis/types-new-relic-api-keys
-
 */
 package entities

pkg/events/doc.go

@@ -1,13 +1,12 @@
 /*
 Package events provides a programmatic API for creating custom events in New Relic.
 
-Authentication
+# Authentication
 
 You will need a valid Insights insert key to communicate with the backend New Relic
 API that provides this functionality.  See the API key documentation below for
 more information on how to locate this key:
 
 https://docs.newrelic.com/docs/apis/get-started/intro-apis/types-new-relic-api-keys
-
 */
 package events

pkg/events/events_batch.go

@@ -136,11 +136,9 @@ func (e *Events) Flush() error {
 	return nil
 }
 
-//
 // batchWorker reads []byte from the queue until a threshold is passed,
 // then copies the []byte it has read and sends that batch along to Insights
 // in its own goroutine.
-//
 func (e *Events) batchWorker(ctx context.Context, id int) (err error) {
 	if e == nil {
 		return errors.New("batchWorker: invalid Events, unable to start worker")
@@ -173,10 +171,8 @@ func (e *Events) batchWorker(ctx context.Context, id int) (err error) {
 	}
 }
 
-//
 // watchdog has a Timer that will send the results once the
 // it has expired.
-//
 func (e *Events) watchdog(ctx context.Context) (err error) {
 	if e.eventTimer == nil {
 		return errors.New("invalid timer for watchdog()")