feat(dashboards): add yAxisRight, isLabelVisible and alter the functi…

…oning of thresholds (#1144)
newrelic · May 23, 2024 · 1c48ee1 · 1c48ee1
1 parent 818be66
commit 1c48ee1
Show file tree

Hide file tree

Showing 2 changed files with 59 additions and 9 deletions.
diff --git a/pkg/dashboards/dashboards_types.go b/pkg/dashboards/dashboards_types.go
@@ -1,6 +1,8 @@
 package dashboards
 
-import "time"
+import (
+	"time"
+)
 
 // Dashboard represents information about a New Relic dashboard.
 type Dashboard struct {
@@ -305,14 +307,14 @@ type RawConfiguration struct {
 	// Used by viz.markdown
 	Text string `json:"text,omitempty"`
 
-	// Used by viz.billboard
-	Thresholds []DashboardBillboardWidgetThresholdInput `json:"thresholds,omitempty"`
-	Legend     *DashboardWidgetLegend                   `json:"legend,omitempty"`
-	YAxisLeft  *DashboardWidgetYAxisLeft                `json:"yAxisLeft,omitempty"`
-	NullValues *DashboardWidgetNullValues               `json:"nullValues,omitempty"`
-	Units      *DashboardWidgetUnits                    `json:"units,omitempty"`
-	Colors     *DashboardWidgetColors                   `json:"colors,omitempty"`
-	Facet      *DashboardWidgetFacet                    `json:"facet,omitempty"`
+	Thresholds interface{}                `json:"thresholds,omitempty"`
+	Legend     *DashboardWidgetLegend     `json:"legend,omitempty"`
+	YAxisLeft  *DashboardWidgetYAxisLeft  `json:"yAxisLeft,omitempty"`
+	YAxisRight *DashboardWidgetYAxisRight `json:"yAxisRight,omitempty"`
+	NullValues *DashboardWidgetNullValues `json:"nullValues,omitempty"`
+	Units      *DashboardWidgetUnits      `json:"units,omitempty"`
+	Colors     *DashboardWidgetColors     `json:"colors,omitempty"`
+	Facet      *DashboardWidgetFacet      `json:"facet,omitempty"`
 }
 
 // RawConfigurationPlatformOptions represents the platform widget options
@@ -330,6 +332,19 @@ type DashboardWidgetYAxisLeft struct {
 	Zero *bool    `json:"zero,omitempty"`
 }
 
+type DashboardWidgetYAxisRight struct {
+	Max    float64                           `json:"max,omitempty"`
+	Min    *float64                          `json:"min,omitempty"`
+	Zero   *bool                             `json:"zero,omitempty"`
+	Series []DashboardWidgetYAxisRightSeries `json:"series,omitempty"`
+}
+
+type DashboardWidgetYAxisRightSeries struct {
+	Name DashboardWidgetYAxisRightSeriesName `json:"name,omitempty"`
+}
+
+type DashboardWidgetYAxisRightSeriesName string
+
 type DashboardWidgetNullValues struct {
 	NullValue       string                              `json:"nullValue,omitempty"`
 	SeriesOverrides []DashboardWidgetNullValueOverrides `json:"seriesOverrides,omitempty"`

diff --git a/pkg/dashboards/type_overrides.go b/pkg/dashboards/type_overrides.go
@@ -9,3 +9,38 @@ type DashboardBillboardWidgetThresholdInput struct {
 	// value.
 	Value *float64 `json:"value,omitempty"`
 }
+
+type DashboardLineWidgetThresholdInput struct {
+	IsLabelVisible *bool                                        `json:"isLabelVisible,omitempty"`
+	Thresholds     []DashboardLineWidgetThresholdThresholdInput `json:"thresholds,omitempty"`
+}
+
+type DashboardLineWidgetThresholdThresholdInput struct {
+	From     *int                                   `json:"from,omitempty"`
+	To       *int                                   `json:"to,omitempty"`
+	Name     string                                 `json:"name,omitempty"`
+	Severity DashboardLineTableWidgetsAlertSeverity `json:"severity,omitempty"`
+}
+
+type DashboardTableWidgetThresholdInput struct {
+	From       *int                                   `json:"from,omitempty"`
+	To         *int                                   `json:"to,omitempty"`
+	ColumnName string                                 `json:"columnName,omitempty"`
+	Severity   DashboardLineTableWidgetsAlertSeverity `json:"severity,omitempty"`
+}
+
+type DashboardLineTableWidgetsAlertSeverity string
+
+var DashboardLineTableWidgetsAlertSeverityTypes = struct {
+	SUCCESS     DashboardLineTableWidgetsAlertSeverity
+	WARNING     DashboardLineTableWidgetsAlertSeverity
+	UNAVAILABLE DashboardLineTableWidgetsAlertSeverity
+	SEVERE      DashboardLineTableWidgetsAlertSeverity
+	CRITICAL    DashboardLineTableWidgetsAlertSeverity
+}{
+	SUCCESS:     "success",
+	WARNING:     "warning",
+	UNAVAILABLE: "unavailable",
+	SEVERE:      "severe",
+	CRITICAL:    "critical",
+}