Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entity): Entity guid validation #1605

Merged
merged 3 commits into from
May 14, 2024
Merged

feat(entity): Entity guid validation #1605

merged 3 commits into from
May 14, 2024

Conversation

NSSPKrishna
Copy link
Member

@NSSPKrishna NSSPKrishna commented May 9, 2024

This change will ensure that the customer-provided GUID is valid before it is accepted by the CLI, preventing any potential issues or errors that may arise from invalid input

Nandu-pns
Nandu-pns previously approved these changes May 10, 2024
@NSSPKrishna
Copy link
Member Author

@Nandu-pns , I have moved the code to client-go for better reusability over CLI. newrelic/newrelic-client-go#1138

@NSSPKrishna
Copy link
Member Author

NOTE: should update the client's version after its release

@NSSPKrishna NSSPKrishna merged commit 6a3bd42 into main May 14, 2024
25 of 26 checks passed
@NSSPKrishna NSSPKrishna deleted the fix/guid-validation branch May 14, 2024 13:17
pranav-new-relic added a commit that referenced this pull request May 15, 2024
@NSSPKrishna NSSPKrishna restored the fix/guid-validation branch May 22, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants