Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop entity-scoped nerdstorage writes #1550

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

amolero-nr
Copy link
Contributor

Removes status report writes to entity-scoped nerdstorage. Ref: NR-185955.

@amolero-nr amolero-nr changed the title Stop entity scoped nerdstorage writes Stop entity-scoped nerdstorage writes Jan 23, 2024
@amolero-nr amolero-nr marked this pull request as ready for review January 23, 2024 14:20
@michaelkro
Copy link
Contributor

I am not sure how this is possible, but I compiled the CLI locally, using this branch, and when I run an install on a host, I'm seeing the install results being written to NerdStorage

@amolero-nr
Copy link
Contributor Author

I'll share with you a brief demo to see if we are on the same page in regards to the install results...

Copy link
Contributor

@michaelkro michaelkro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by compiling the CLI locally, running it against a fresh EC2 instance, and confirming that events are not being written to entity nerdstorage.

@amolero-nr amolero-nr merged commit efef411 into main Jan 25, 2024
24 of 25 checks passed
@amolero-nr amolero-nr deleted the chore/NR-185955-stop-entity-scope-nerdstorage-writes branch January 25, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants