Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validation nrql backup functionality #1519

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

noahmmcgivern
Copy link
Contributor

@noahmmcgivern noahmmcgivern commented Oct 6, 2023

Makes validationNrql an additional method of validating OHI installation. The result is that the first successful method of validation will count as a successful installation. If all methods fail, the installation is considered to have failed.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #1519 (38da97a) into main (345fe44) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1519      +/-   ##
==========================================
+ Coverage   47.38%   47.40%   +0.02%     
==========================================
  Files         125      125              
  Lines        7713     7716       +3     
==========================================
+ Hits         3655     3658       +3     
  Misses       3917     3917              
  Partials      141      141              
Files Coverage Δ
internal/install/recipe_installer.go 80.03% <100.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@noahmmcgivern noahmmcgivern merged commit 87a754a into main Oct 6, 2023
26 checks passed
@noahmmcgivern noahmmcgivern deleted the fix/validation-nrql-backup-functionality branch October 6, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants