Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(install): include validationNRQL as install validation fallback to validationIntegration #1517

Closed
wants to merge 1 commit into from

Conversation

sanderblue
Copy link
Contributor

@sanderblue sanderblue commented Oct 5, 2023

After discovering a weird local validation bug with MongoDB and MSSQL, we need to be defensive with how we validation installations until we can figure out the oddity with the hanging execution on Windows environments.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1517 (db883c1) into main (7267381) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1517   +/-   ##
=======================================
  Coverage   47.38%   47.38%           
=======================================
  Files         125      125           
  Lines        7713     7713           
=======================================
  Hits         3655     3655           
  Misses       3917     3917           
  Partials      141      141           
Files Coverage Δ
internal/install/recipe_installer.go 79.92% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sanderblue sanderblue closed this Oct 6, 2023
@sanderblue sanderblue deleted the hotfix/local-validation branch October 6, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant