Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(install): Improve network error detection and messaging #1438

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

rthorn-nr
Copy link
Contributor

Moves the call to checkNetwork() from inside the installer to before fetching the license key. Also adds more descriptive and helpful error messages if checkNetwork() fails.

@rthorn-nr rthorn-nr requested review from NRhzhao and mbruzina March 22, 2023 01:45
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@33e8e38). Click here to learn what that means.
The diff coverage is 0.00%.

❗ Current head 0a2dfa3 differs from pull request most recent head 5dfd621. Consider uploading reports for the commit 5dfd621 to get more accurate results

@@           Coverage Diff           @@
##             main    #1438   +/-   ##
=======================================
  Coverage        ?   47.54%           
=======================================
  Files           ?      120           
  Lines           ?     7174           
  Branches        ?        0           
=======================================
  Hits            ?     3411           
  Misses          ?     3627           
  Partials        ?      136           
Impacted Files Coverage Δ
internal/install/command.go 8.75% <0.00%> (ø)
internal/install/recipe_installer.go 78.03% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mbruzina
mbruzina previously approved these changes Mar 22, 2023
chore(install): Log proxy config
@rthorn-nr rthorn-nr force-pushed the chore/improve-network-errors branch from 0a2dfa3 to 5dfd621 Compare March 22, 2023 17:43
@rthorn-nr rthorn-nr merged commit 6e6a005 into main Mar 22, 2023
@rthorn-nr rthorn-nr deleted the chore/improve-network-errors branch March 22, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants