Improve proxy support for install scripts #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rthorn-nr
force-pushed
the
NR-68284/install-script-proxy-support
branch
from
31c13c8 to
239fe19
Compare
Codecov Report
@@ Coverage Diff @@
## main #1432 +/- ##
==========================================
+ Coverage 47.54% 47.61% +0.06%
==========================================
Files 120 120
Lines 7163 7163
==========================================
+ Hits 3406 3411 +5
+ Misses 3622 3618 -4
+ Partials 135 134 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Julien4218
reviewed
Feb 23, 2023
Julien4218
reviewed
Feb 23, 2023
Julien4218
reviewed
Feb 23, 2023
Julien4218
previously approved these changes
Feb 24, 2023
chore: Add proxy connection message to ps1 chore: Add connection check & proxy message to sh chore: Get proxy URL from env chore: Move file dl to try block; output err
rthorn-nr
force-pushed
the
NR-68284/install-script-proxy-support
branch
from
dc948af to
a12b670
Compare
Julien4218
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
install.shandinstall.ps1, check for connectivity tohttps://download.newrelic.comand provide a helpful message if unable to connect.For
install.ps1, adds a proxy to the requestingWebClientvia the optional environment variableHTTPS_PROXY, which will enable setting a proxy for the CLI download.