Skip to content

Commit

Permalink
chore(release): temp disable windows release while we work on fixing …
Browse files Browse the repository at this point in the history
…PFX cert issue
  • Loading branch information
sanderblue committed Apr 30, 2024
1 parent 303e8bd commit dde7407
Showing 1 changed file with 45 additions and 45 deletions.
90 changes: 45 additions & 45 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,30 +92,30 @@ jobs:
./scripts/win_metadata_files_remove.sh
# Note the uploaded binary is downloaded and used in the release-windows-installer job
- name: Upload Windows binary to GitHub
uses: actions/upload-artifact@v3
with:
name: windows-binary
path: dist/newrelic_windows_amd64_v1/newrelic.exe

- name: Sign newrelic.exe
shell: bash
env:
PFX_CONTENT: ${{ secrets.PFX_BASE64_CONTENT }}
PFX_PASSWORD: ${{ secrets.PFX_CERT_PASSWORD }}
run: |
echo "$PFX_CONTENT" | base64 -d > cert.pfx
sudo apt-get install osslsigncode -y
sudo mv dist/newrelic_windows_amd64_v1/newrelic.exe dist/newrelic_windows_amd64_v1/newrelic-unsigned.exe
osslsigncode sign -pkcs12 cert.pfx -pass "$PFX_PASSWORD" -h sha512 -t http://timestamp.digicert.com \
-in dist/newrelic_windows_amd64_v1/newrelic-unsigned.exe -out dist/newrelic_windows_amd64_v1/newrelic.exe
rm -f cert.pfx dist/newrelic_windows_amd64_v1/newrelic-unsigned.exe
- name: Re-do Windows_x86_64.zip
run: |
VERSION=$(ls dist/*Windows_x86_64.zip | cut -d_ -f2)
rm -f dist/newrelic-cli_${VERSION}_Windows_x86_64.zip
zip -q dist/newrelic-cli_${VERSION}_Windows_x86_64.zip dist/newrelic_windows_amd64_v1/newrelic.exe
# - name: Upload Windows binary to GitHub
# uses: actions/upload-artifact@v3
# with:
# name: windows-binary
# path: dist/newrelic_windows_amd64_v1/newrelic.exe

# - name: Sign newrelic.exe
# shell: bash
# env:
# PFX_CONTENT: ${{ secrets.PFX_BASE64_CONTENT }}
# PFX_PASSWORD: ${{ secrets.PFX_CERT_PASSWORD }}
# run: |
# echo "$PFX_CONTENT" | base64 -d > cert.pfx
# sudo apt-get install osslsigncode -y
# sudo mv dist/newrelic_windows_amd64_v1/newrelic.exe dist/newrelic_windows_amd64_v1/newrelic-unsigned.exe
# osslsigncode sign -pkcs12 cert.pfx -pass "$PFX_PASSWORD" -h sha512 -t http://timestamp.digicert.com \
# -in dist/newrelic_windows_amd64_v1/newrelic-unsigned.exe -out dist/newrelic_windows_amd64_v1/newrelic.exe
# rm -f cert.pfx dist/newrelic_windows_amd64_v1/newrelic-unsigned.exe

# - name: Re-do Windows_x86_64.zip
# run: |
# VERSION=$(ls dist/*Windows_x86_64.zip | cut -d_ -f2)
# rm -f dist/newrelic-cli_${VERSION}_Windows_x86_64.zip
# zip -q dist/newrelic-cli_${VERSION}_Windows_x86_64.zip dist/newrelic_windows_amd64_v1/newrelic.exe

- name: Install AWS CLI
run: |
Expand Down Expand Up @@ -162,24 +162,24 @@ jobs:
rm -rf /home/runner/.aws/credentials
rm -rf /home/runner/.aws/config
release-windows-installer:
if: github.ref == 'refs/heads/main'
needs: release
uses: newrelic/newrelic-cli/.github/workflows/release-windows-installer.yml@main
secrets:
PFX_BASE64_CONTENT: ${{ secrets.PFX_BASE64_CONTENT }}
PFX_CERT_PASSWORD: ${{ secrets.PFX_CERT_PASSWORD }}
RELEASE_TOKEN: ${{ secrets.RELEASE_TOKEN }}

publish:
if: github.ref == 'refs/heads/main'
needs: release-windows-installer
uses: newrelic/newrelic-cli/.github/workflows/release-publish-windows.yml@main
secrets:
RELEASE_TOKEN: ${{ secrets.RELEASE_TOKEN }}
DEV_TOOLKIT_TOKEN: ${{ secrets.DEV_TOOLKIT_TOKEN }}
CHOCOLATEY_API_KEY: ${{ secrets.CHOCOLATEY_API_KEY }}
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_ROLE_ARN: ${{ secrets.AWS_ROLE_ARN }}
AWS_DEFAULT_REGION: ${{ secrets.AWS_DEFAULT_REGION }}
# release-windows-installer:
# if: github.ref == 'refs/heads/main'
# needs: release
# uses: newrelic/newrelic-cli/.github/workflows/release-windows-installer.yml@main
# secrets:
# PFX_BASE64_CONTENT: ${{ secrets.PFX_BASE64_CONTENT }}
# PFX_CERT_PASSWORD: ${{ secrets.PFX_CERT_PASSWORD }}
# RELEASE_TOKEN: ${{ secrets.RELEASE_TOKEN }}

# publish:
# if: github.ref == 'refs/heads/main'
# needs: release-windows-installer
# uses: newrelic/newrelic-cli/.github/workflows/release-publish-windows.yml@main
# secrets:
# RELEASE_TOKEN: ${{ secrets.RELEASE_TOKEN }}
# DEV_TOOLKIT_TOKEN: ${{ secrets.DEV_TOOLKIT_TOKEN }}
# CHOCOLATEY_API_KEY: ${{ secrets.CHOCOLATEY_API_KEY }}
# AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
# AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
# AWS_ROLE_ARN: ${{ secrets.AWS_ROLE_ARN }}
# AWS_DEFAULT_REGION: ${{ secrets.AWS_DEFAULT_REGION }}

0 comments on commit dde7407

Please sign in to comment.