Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Capture Internal Metrics for Session Replay Configurations #879

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Feb 7, 2024

Capture supportability metrics sounding Session Replay configuration usage to improve user experiences around configuration of the agent's Session Replay feature.

Overview

Related Issue(s)

NR-221612

Angler -> https://source.datanerd.us/agents/angler/pull/545

Testing

A jest test has been updated to account for moving the configuration getters out of the flag promise for better DRY mechanics.

Copy link

github-actions bot commented Feb 7, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.46 kB / 10.66 kB (gzip) 30.46 kB / 10.66 kB (gzip) 0% / 0% (gzip)
lite async-chunk 45.86 kB / 15.1 kB (gzip) 45.86 kB / 15.1 kB (gzip) 0% / 0% (gzip)
pro loader 49.13 kB / 16.74 kB (gzip) 49.13 kB / 16.75 kB (gzip) 0% / 0.01% (gzip)
pro async-chunk 74.41 kB / 23.52 kB (gzip) 74.77 kB / 23.6 kB (gzip) 0.48% / 0.35% (gzip)
spa loader 55.6 kB / 18.72 kB (gzip) 55.6 kB / 18.72 kB (gzip) 0% / 0% (gzip)
spa async-chunk 89.18 kB / 27.91 kB (gzip) 89.54 kB / 28 kB (gzip) 0.4% / 0.33% (gzip)
lite-polyfills loader 125.12 kB / 39.91 kB (gzip) 125.12 kB / 39.91 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 58.23 kB / 17.2 kB (gzip) 58.23 kB / 17.2 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 144.68 kB / 45.66 kB (gzip) 144.68 kB / 45.66 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 101.8 kB / 27.58 kB (gzip) 101.8 kB / 27.58 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 152.7 kB / 47.8 kB (gzip) 152.7 kB / 47.8 kB (gzip) 0% / 0% (gzip)
spa-polyfills async-chunk 117.36 kB / 32.56 kB (gzip) 117.36 kB / 32.56 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7455635) 78.67% compared to head (0905e41) 78.66%.

Files Patch % Lines
src/features/session_replay/aggregate/index.js 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
- Coverage   78.67%   78.66%   -0.02%     
==========================================
  Files         145      145              
  Lines        6519     6525       +6     
  Branches     1267     1267              
==========================================
+ Hits         5129     5133       +4     
- Misses       1181     1183       +2     
  Partials      209      209              
Flag Coverage Δ
unit-tests 55.52% <75.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 7, 2024

Static Badge

Last ran on February 07, 2024 18:17:06 CST
Checking merge of (0905e41) into main (7455635)

@metal-messiah metal-messiah merged commit f60e7f1 into main Feb 8, 2024
50 of 52 checks passed
@metal-messiah metal-messiah deleted the sampling-sms branch February 8, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants