Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabling sri integration #835

Closed
wants to merge 1 commit into from
Closed

fix: disabling sri integration #835

wants to merge 1 commit into from

Conversation

patrickhousley
Copy link
Contributor

A bug has been found with the agent build and SRI integration. The SRI usage within the agent is being disabled to prevent issues with session replay limited preview.

Overview

Disabled the SRI plugin and test for now. Also removed the custom plugins and converted our chunking to standard webpack configuration.

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-189746

Testing

Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.39 kB / 10.55 kB (gzip) 30.22 kB / 10.42 kB (gzip) -0.55% / -1.2% (gzip)
lite async-chunk 45.58 kB / 15.05 kB (gzip) 45.58 kB / 15.05 kB (gzip) 0% / 0% (gzip)
pro loader 47.79 kB / 15.97 kB (gzip) 47.62 kB / 15.84 kB (gzip) -0.35% / -0.8% (gzip)
pro async-chunk 74.48 kB / 23.75 kB (gzip) 74.48 kB / 23.75 kB (gzip) 0% / 0% (gzip)
spa loader 54.24 kB / 17.95 kB (gzip) 54.07 kB / 17.82 kB (gzip) -0.31% / -0.7% (gzip)
spa async-chunk 89.25 kB / 28.16 kB (gzip) 89.25 kB / 28.16 kB (gzip) 0% / 0% (gzip)
lite-polyfills loader 122.23 kB / 39.63 kB (gzip) 122.07 kB / 39.51 kB (gzip) -0.14% / -0.32% (gzip)
lite-polyfills async-chunk 57.97 kB / 17.25 kB (gzip) 57.97 kB / 17.25 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 141.79 kB / 45.4 kB (gzip) 141.62 kB / 45.28 kB (gzip) -0.12% / -0.27% (gzip)
pro-polyfills async-chunk 101.74 kB / 27.34 kB (gzip) 101.74 kB / 27.34 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 149.81 kB / 47.54 kB (gzip) 149.64 kB / 47.42 kB (gzip) -0.11% / -0.25% (gzip)
spa-polyfills async-chunk 117.31 kB / 31.93 kB (gzip) 117.31 kB / 31.93 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e3b810) 78.24% compared to head (5438635) 78.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #835   +/-   ##
=======================================
  Coverage   78.24%   78.24%           
=======================================
  Files         142      142           
  Lines        6358     6358           
  Branches     1228     1228           
=======================================
  Hits         4975     4975           
  Misses       1176     1176           
  Partials      207      207           
Flag Coverage Δ
unit-tests 55.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patrickhousley
Copy link
Contributor Author

This may not need to be merged if we merge #837

@patrickhousley patrickhousley deleted the disable-sri branch July 23, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants