-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: loader missing sub-resource integrity hashes #837
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
=======================================
Coverage 78.24% 78.24%
=======================================
Files 142 142
Lines 6358 6358
Branches 1228 1228
=======================================
Hits 4975 4975
Misses 1176 1176
Partials 207 207
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built & confirmed each plugins is doing its work.
Sub-resource integrity hashes were not being properly generated and included in the loader for async chunks related to session replay. This would cause a warning to appear in the browser console but would not block those chunks from loading. This would have only affected customers taking part in the session replay limited preview.
Overview
This problem was caused by a couple of issues:
Change Highlights:
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-189746
Testing
The SRI integration test has been updated to force session replay and verify all chunks were loaded with integrity hashes.