Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: health sidecar #112

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: health sidecar #112

wants to merge 15 commits into from

Conversation

danielstokes
Copy link
Contributor

Description

Adds health APM support.

TODO:

  • Add tests
  • Fix Restart policy 1

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

Footnotes

  1. requires https://github.com/newrelic/k8s-agents-operator/pull/110 before this can work.

@danielstokes danielstokes requested a review from a team as a code owner October 23, 2024 20:39
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 89.20863% with 15 lines in your changes missing coverage. Please review.

Project coverage is 62.71%. Comparing base (dbfec23) to head (ac2ab09).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/apm/health.go 89.20% 10 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   60.25%   62.71%   +2.45%     
==========================================
  Files          21       23       +2     
  Lines        1472     1671     +199     
==========================================
+ Hits          887     1048     +161     
- Misses        519      548      +29     
- Partials       66       75       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

)

const (
envHealthFleetControlFile = "NEW_RELIC_FLEET_CONTROL_HEALTH_FILE"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
envHealthFleetControlFile = "NEW_RELIC_FLEET_CONTROL_HEALTH_FILE"
envHealthFleetControlFilePath = "NEW_RELIC_FLEET_CONTROL_HEALTH_PATH"

@danielstokes We needed to rename this env var since we will have multiple health files in some cases like Python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants