This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
Fetch files with Github API #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add a custom hook for grabbing query parameters off the location object * use hook in preview page to grab and log out the 'pr' and 'quickstart' query parameters
* Ability to grab both the quickstart filepath and SHA from one fetch request
josephgregoryii
commented
May 12, 2022
aswanson-nr
reviewed
May 12, 2022
There was a problem hiding this comment.
Hey @josephgregoryii! I had one big comment on the recursive function, please let me know if that does/doesn't make any sense. The rest are just around finishing up the AC and some small naming comments!
* Added logic to handle redirecting a contributor to the homepage if query parameters are not set
josephgregoryii
commented
May 13, 2022
aswanson-nr
reviewed
May 13, 2022
aswanson-nr
reviewed
May 16, 2022
* Moved helper functions to src/utils/helpers * Moved URL constants to src/data/
aswanson-nr
approved these changes
May 16, 2022
zstix
reviewed
May 16, 2022
zstix
reviewed
May 16, 2022
* Removed try catch block to favor error stack in preview page
aswanson-nr
approved these changes
May 16, 2022
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary