Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: set up some tests for ASG and launchtemplate #37

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

rudoi
Copy link

@rudoi rudoi commented Jul 27, 2020

the update PR needs to go in first

@rudoi rudoi requested a review from mytunguyen July 27, 2020 15:58
@rudoi rudoi force-pushed the rudoi/launch-tests branch from f2e6998 to f0bf9b2 Compare July 27, 2020 15:59
@rudoi rudoi force-pushed the rudoi/launch-tests branch from 340bc1b to ea8cdfc Compare July 27, 2020 16:05
@rudoi rudoi requested a review from nicoleyson July 27, 2020 16:06
Copy link

@nicoleyson nicoleyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 👍

Copy link

@mytunguyen mytunguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rudoi rudoi merged commit 52a2735 into machinepools Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants