Migration Prep/Release 3.2.0 #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p-plugin-mojo into feature/migration * 'feature/migration' of https://github.com/newfold-labs/wp-plugin-mojo: WordPress i18n triggered by commit 644bbf8
…p-plugin-mojo into feature/migration * 'feature/migration' of https://github.com/newfold-labs/wp-plugin-mojo: WordPress i18n triggered by commit 7c93876
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||
8 tasks
due to the plugin slug being in flux here, we'll skip this test for now and hopefully can work it back in soon.
…p-plugin-mojo into feature/migration * 'feature/migration' of https://github.com/newfold-labs/wp-plugin-mojo: WordPress i18n triggered by commit 94046aa
exclude the wp 6.6 and php 7.1 matrix since that version of wp requires 7.2+
|
Can I get a review here now that all the tests are passing? The only thing I don't like is I had to exclude the deactivation survey tests since the plugin slug is being changed from the folder structure. I'll work on getting it back once I get this release out. |
wpscholar
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This preps to migrate the legacy mojo plugin to this newer one.
We need to update the plugin slug to match the legacy version so we can then update the update path to point to this plugin rather than the old one.
This also updates the WP version and bumps the plugin version.
See PRESS1-232
Type of Change
Video
Checklist
Further comments