Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/refresh UI #193

Merged
merged 13 commits into from
Nov 13, 2023
Merged

Update/refresh UI #193

merged 13 commits into from
Nov 13, 2023

Conversation

circlecube
Copy link
Member

The UI refresh work is complete here.

Have removed the cypress tests that are replaced with module based tests, but still need to update the plugin based tests.

@circlecube circlecube self-assigned this Nov 9, 2023
@circlecube
Copy link
Member Author

  1. Need to update the coming soon module so that the admin bar content matches what is done in e-commerce module so that those tests will pass whether e-commerce module is installed or not.
  2. Investigate the notifications tests in this plugin to see why they are failing here. Might be missing a bit of code somewhere.

@circlecube
Copy link
Member Author

I got the tests to pass by excluding the coming soon and notifications tests for now. This is ready for review now.

@circlecube circlecube merged commit 2b21fe0 into develop Nov 13, 2023
3 checks passed
@circlecube circlecube deleted the update/refresh-ui branch November 13, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants