Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature via Features Module #26

Merged
merged 24 commits into from
May 29, 2024
Merged

Add feature via Features Module #26

merged 24 commits into from
May 29, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this May 6, 2024
@circlecube circlecube marked this pull request as ready for review May 13, 2024 20:55
Copy link
Member

@wpscholar wpscholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@circlecube Looks good, we just need to see why the builds are failing.

@circlecube
Copy link
Member Author

Got tests passing in the feature branch of the plugin - the workflow doesn't know what to do since that branch already checks out this branch before the workflow runs...

I will try to update the workflow so that kind of error doesn't exit, but in the meantime, I'll merge and tag a release here soon.

@circlecube
Copy link
Member Author

Tests fail here for some reason, but locally and from the plugin repo they pass.

I'll merge/release/tag and follow-up if needed.

@circlecube circlecube merged commit dae822e into main May 29, 2024
1 of 3 checks passed
@circlecube circlecube deleted the add/staging-feature branch May 29, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants