Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press0 1122 #23

Merged
merged 18 commits into from
Apr 23, 2024
Merged

Press0 1122 #23

merged 18 commits into from
Apr 23, 2024

Conversation

aratidgr8
Copy link
Contributor

Proposed changes

Updated README.md file, with Module responsibilities & Critical paths information.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@aratidgr8 aratidgr8 requested a review from wpscholar April 12, 2024 08:34
Copy link
Member

@wpscholar wpscholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you crate JIRA tickets for the things that should be different about the module?

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@aratidgr8 aratidgr8 requested a review from wpscholar April 19, 2024 08:58
Copy link
Member

@wpscholar wpscholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdown formatting is a bit off. See https://github.com/newfold-labs/wp-module-runtime/blob/PRESS0-1122/README.md

Can you update so it formats correctly?

Also, let's change the primary title on the readme from wp-module-runtime to WordPress Runtime Module

@aratidgr8 aratidgr8 requested a review from wpscholar April 23, 2024 07:11
@wpscholar wpscholar merged commit a3ec8ba into trunk Apr 23, 2024
@wpscholar wpscholar deleted the PRESS0-1122 branch April 23, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants