Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide more flexibility when loading runtime JS #14

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Provide more flexibility when loading runtime JS #14

merged 5 commits into from
Oct 5, 2023

Conversation

ramyakrishnai
Copy link
Contributor

No description provided.

@ramyakrishnai ramyakrishnai linked an issue Sep 25, 2023 that may be closed by this pull request
Provide more flexibility when loading runtime JS #6
Closed
circlecube
circlecube requested changes Sep 29, 2023
View reviewed changes
includes/runtime.js Outdated Show resolved Hide resolved
includes/Runtime.php Outdated Show resolved Hide resolved
includes/runtime.js Outdated Show resolved Hide resolved
@circlecube
Update Runtime.php
781ba7c 
Update handle for the inline script too.

We want the inline to load anytime a script denotes a dependency on the runtime script.
circlecube
circlecube previously approved these changes Oct 3, 2023
View reviewed changes
wpscholar
wpscholar approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@wpscholar wpscholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to make sure and explicitly add the nfd-runtime script as a JS dependency of any script that depends on the runtime module.

@wpscholar wpscholar merged commit 55e1b1a into trunk Oct 5, 2023
@wpscholar wpscholar deleted the PRESS4-306 branch October 5, 2023 14:56
@wpscholar wpscholar mentioned this pull request Oct 5, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpscholar wpscholar wpscholar approved these changes

@circlecube circlecube circlecube left review comments

@aratidgr8 aratidgr8 Awaiting requested review from aratidgr8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide more flexibility when loading runtime JS
3 participants
@ramyakrishnai @circlecube @wpscholar