-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert this module into a runtime package #12
Conversation
Thanks @ramyakrishnai, Let's hold on merging this just yet. After discussions with @arunshenoy99 about how we'll handle modules moving forward, I think we will stick with the Additionally, in the if ( function_exists( 'add_action' ) ) {
add_action(
'newfold_container_set',
function ( $container ) {
$runtime = new Runtime( $container );
$runtime->loadIntoPage( 'admin_enqueue_scripts' );
}
);
} |
hi @wpscholar , I also tried with this https://github.com/newfold-labs/wp-module-data/blob/main/bootstrap.php#L79-L109 but it is still throiwng the same error I'm sharing the error here and also attached a screenshot for your reference ** Could you please assist me with this. Thank you! |
These errors look like the runtime object wasn't set up properly so when the app tried to find the We'll still need to use the Wordpress hook to add the code ( |
Hi @circlecube , I've checked with the @wpscholar suggestion and getting the error as shown above. Like I mean NewfoldRuntime is not getting loaded correctly. So, could you please assist with this ? Thank you |
@ramyakrishnai We can't assist if your latest code isn't in the PR. Can you push the change anyway so we can pull down and test? |
Hi @wpscholar , I've pushed the code and updated my pr with latest code. Thank you |
Will address #2