-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link prefetch new feature #26
link prefetch new feature #26
Conversation
Awaiting code review from @arunshenoy99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @geckod22, thank you for the PR! Great work, especially since this is your first time working on this codebase. I’ve added a few minor comments and suggestions for optimisations. Please check and let me know if they make sense.
Also:
- Let’s make sure to run the
wp-scripts
linter on the JS files. - Let’s add a newline at the end of each file to maintain consistency.
Co-authored-by: Arun Shenoy <[email protected]>
Co-authored-by: Arun Shenoy <[email protected]>
…tainer set in performance.php
Co-authored-by: Arun Shenoy <[email protected]>
Co-authored-by: Arun Shenoy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks a lot @geckod22
…odule-performance into enhance/PRESS7-64-link-prefetch
Proposed changes
The changes are to add a new feature to the module called Link Prefetch. This make the admin able to set if and how the links should be prefetched to provide a faster navigation among the pages.
https://jira.newfold.com/browse/PRESS7-64
Type of Change
Video
Checklist
Further comments
Depending on the selected options, the frontend js will manage the behaviour of this feature as explained in the options description texts. It will add a link rel=prefetch tag in the page header.
On Desktop:
On Mobile: