Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add htaccess var to class to stop throw warning for dynamic property creation #23

Merged
merged 1 commit into from
May 29, 2024
Merged

add htaccess var to class to stop throw warning for dynamic property creation #23

merged 1 commit into from
May 29, 2024

Conversation

circlecube
Copy link
Member

add htaccess var to class to stop throw warning for dynamic property creation

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested review from wpscholar and wpalani May 28, 2024 21:27
@circlecube circlecube self-assigned this May 28, 2024
@circlecube
Copy link
Member Author

See PRESS0-1336

@circlecube circlecube merged commit 40f6e72 into main May 29, 2024
3 of 6 checks passed
@circlecube circlecube deleted the fix/php-deprecation-warning branch May 29, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desrosj desrosj desrosj approved these changes

@wpscholar wpscholar Awaiting requested review from wpscholar

@wpalani wpalani Awaiting requested review from wpalani

Assignees

@circlecube circlecube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@circlecube @desrosj