Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Theme Customizations Instead of Child Themes #613

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented Aug 27, 2024

Proposed changes

Story: https://jira.newfold.com/browse/PRESS0-1919

This moves the DIY flow away from child theme generation to using theme customizations by doing the following:

  1. Using custom style variations for theme.json customizations.
  2. Using template part customization for updating template parts.
  3. Programmatically deselecting inactive fonts so that they are not written into the DOM during rendering.
  4. Keeping YITH Wonder as the active theme.
  5. Completely removing child theme generation.

Tests are failing as we need: newfold-labs/wp-module-onboarding-data#111

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 added the Code Review The PR is in Code Review label Aug 27, 2024
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@officiallygod officiallygod added QA This PR is in QA and removed Code Review The PR is in Code Review labels Aug 28, 2024
@arunshenoy99 arunshenoy99 added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Sep 10, 2024
@arunshenoy99 arunshenoy99 merged commit da65cd8 into trunk Sep 11, 2024
5 checks passed
@arunshenoy99 arunshenoy99 deleted the enhance/theme-customization branch September 11, 2024 06:51
@0aveRyan 0aveRyan restored the enhance/theme-customization branch September 30, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants