Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Onboarding Flow GET Error #612

Merged
merged 7 commits into from
Sep 11, 2024
Merged

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Aug 27, 2024

Proposed changes

  1. Added a retry for Flow GET call
  2. Added few checks that prevent crashing of the site

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Aug 27, 2024
@officiallygod officiallygod self-assigned this Aug 27, 2024
@officiallygod officiallygod added Code Review The PR is in Code Review WIP PR is a Work in Progress and not ready for review. and removed WIP PR is a Work in Progress and not ready for review. Code Review The PR is in Code Review labels Aug 28, 2024
@officiallygod officiallygod added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Aug 29, 2024
@arunshenoy99 arunshenoy99 added QA This PR is in QA and removed Code Review The PR is in Code Review labels Aug 29, 2024
@officiallygod
Copy link
Member Author

PRESS0-1951

@officiallygod officiallygod added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Sep 4, 2024
@arunshenoy99 arunshenoy99 merged commit 85242b3 into trunk Sep 11, 2024
5 checks passed
@arunshenoy99 arunshenoy99 deleted the fix/onboarding-flow-error branch September 11, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants