-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
back button hidden on Editor step #593
Conversation
[PRESS0-1551] (https://jira.newfold.com/browse/PRESS0-1551) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Back | ||
path={ | ||
isPreviewStep | ||
? stepSiteGenSiteLogo.path | ||
: previousStep.path | ||
} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think why we included this was when a user does a back on Preview page he ends up on the same page again as the experience redirects him back to this page and he can never go back, But now I am unsure if a user can ever go and change the prompt again, Is that requirement fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are removing the navigation bar itself from the preview step. the check for the isPreviewStep is not relevant anymore on the back button. The behaviour to stay redirect back on the preview step is still the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's confirm if it's OK to hide the header for that step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@officiallygod, @ajayadav09 has confirmed that we have a go ahead.
Proposed changes
JIRA: https://jira.newfold.com/browse/PRESS0-1551
Type of Change
Checklist
Further comments