Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with custom fonts preview #586

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix issue with custom fonts preview #586

merged 1 commit into from
Jun 25, 2024

Conversation

mr-vara
Copy link
Contributor

@mr-vara mr-vara commented Jun 19, 2024

Proposed changes

In SiteGen customisation step, the custom fonts are not getting reflected in the preview. This PR will ensure that the fonts selected are always reflected in the preview.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@mr-vara mr-vara requested a review from arunshenoy99 June 19, 2024 10:56
@arunshenoy99 arunshenoy99 added the QA This PR is in QA label Jun 25, 2024
@mr-vara mr-vara merged commit 8a3f69a into trunk Jun 25, 2024
5 of 6 checks passed
@arunshenoy99 arunshenoy99 deleted the fix/press0-1509 branch September 11, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA This PR is in QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants