Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migration_initiation event from sitebuild #577

Merged
merged 14 commits into from
Jun 27, 2024
Merged

migration_initiation event from sitebuild #577

merged 14 commits into from
Jun 27, 2024

Conversation

ajayadav09
Copy link
Contributor

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@ajayadav09 ajayadav09 self-assigned this Jun 11, 2024
@ajayadav09 ajayadav09 added the WIP PR is a Work in Progress and not ready for review. label Jun 11, 2024
@ajayadav09 ajayadav09 marked this pull request as ready for review June 11, 2024 03:51
@ajayadav09 ajayadav09 added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Jun 17, 2024
officiallygod
officiallygod approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@ajayadav09 ajayadav09 requested a review from officiallygod June 24, 2024 13:18
@ajayadav09 ajayadav09 added QA This PR is in QA and removed Code Review The PR is in Code Review labels Jun 26, 2024
@arunshenoy99 arunshenoy99 added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Jun 27, 2024
@arunshenoy99
Copy link
Member

PRESS0-1517

@arunshenoy99 arunshenoy99 merged commit a4cff78 into trunk Jun 27, 2024
4 of 5 checks passed
@arunshenoy99 arunshenoy99 deleted the migration-event-fix branch June 27, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

Assignees

@ajayadav09 ajayadav09

Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajayadav09 @arunshenoy99 @officiallygod