Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit AI Retries #562

Merged
merged 10 commits into from
May 22, 2024
Merged

Limit AI Retries #562

merged 10 commits into from
May 22, 2024

Conversation

officiallygod
Copy link
Member

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label May 13, 2024
@officiallygod officiallygod self-assigned this May 13, 2024
@officiallygod officiallygod added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels May 16, 2024
@officiallygod
Copy link
Member Author

officiallygod commented May 16, 2024 •
edited
Loading

Onboarding Data: newfold-labs/wp-module-onboarding-data#83
Tests should be working with this PR.

@ajayadav09 ajayadav09 self-requested a review May 16, 2024 17:40
ajayadav09
ajayadav09 reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@ajayadav09 ajayadav09 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the retryCount exceeds the maxRetryCount all the 9 sitemeta apis fail in the first attempt.

src/OnboardingSPA/components/ErrorState/Step/SiteGen/index.js Show resolved Hide resolved
src/OnboardingSPA/components/ErrorState/Step/SiteGen/index.js Show resolved Hide resolved
@officiallygod
Copy link
Member Author

the retryCount exceeds the maxRetryCount all the 9 sitemeta apis fail in the first attempt.

Made sure all of that counts as one, Thanks.

ajayadav09
ajayadav09 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@ajayadav09 ajayadav09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for QA

@ajayadav09 ajayadav09 added QA This PR is in QA and removed Code Review The PR is in Code Review labels May 17, 2024
@officiallygod officiallygod added Code Review The PR is in Code Review and removed QA This PR is in QA labels May 17, 2024
@ajayadav09
Copy link
Contributor

Verified changes for https://jira.newfold.com/browse/PRESS0-1370

@officiallygod officiallygod added QA This PR is in QA Ready to merge The Code Review and QA is done and it can be merged. and removed Code Review The PR is in Code Review QA This PR is in QA labels May 20, 2024
@arunshenoy99 arunshenoy99 merged commit 2cc9877 into trunk May 22, 2024
3 of 5 checks passed
@arunshenoy99 arunshenoy99 deleted the enhance/limit-ai-retries branch May 22, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajayadav09 ajayadav09 ajayadav09 approved these changes

Assignees

@officiallygod officiallygod

Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@officiallygod @ajayadav09 @arunshenoy99