Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tracking Bugs in AI WonderStart Flow #549

Merged
merged 2 commits into from
May 2, 2024
Merged

Fix Tracking Bugs in AI WonderStart Flow #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6a0632
Fix Tracking Bugs in AI WonderStart Flow
arunshenoy99 Apr 24, 2024
e5e443d
Merge branch 'trunk' of https://github.com/newfold-labs/wp-module-onb…
arunshenoy99 May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OnboardingSPA/steps/SiteGen/Editor/Header/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@
await setFlow( currentData );
await completeFlow();
sendOnboardingEvent(
new OnboardingEvent( ACTION_ONBOARDING_COMPLETE, {
new OnboardingEvent( ACTION_ONBOARDING_COMPLETE, undefined, {
source: SITEGEN_FLOW,
} )
);
Expand All @@ -294,7 +294,7 @@

useEffect( () => {
handleCustomize();
}, [] );

Check warning on line 297 in src/OnboardingSPA/steps/SiteGen/Editor/Header/index.js

View workflow job for this annotation

GitHub Actions / Run Lint Checks 

React Hook useEffect has a missing dependency: 'handleCustomize'. Either include it or remove the dependency array

useEffect( () => {
if ( currentData?.sitegen?.homepages?.active ) {
Expand All @@ -312,7 +312,7 @@
return () => {
setInteractionDisabled( false );
};
}, [ isSaving, isRegenerating ] );

Check warning on line 315 in src/OnboardingSPA/steps/SiteGen/Editor/Header/index.js

View workflow job for this annotation

GitHub Actions / Run Lint Checks 

React Hook useEffect has a missing dependency: 'setInteractionDisabled'. Either include it or remove the dependency array

return (
<>
Expand Down
11 changes: 6 additions & 5 deletions src/OnboardingSPA/steps/SiteGen/SiteLogo/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
}
setIsFooterNavAllowed( false );
getEditedEntityRecord( 'root', 'site' );
}, [] );

Check warning on line 73 in src/OnboardingSPA/steps/SiteGen/SiteLogo/index.js

View workflow job for this annotation

GitHub Actions / Run Lint Checks 

React Hook useEffect has missing dependencies: 'currentData.sitegen.siteLogo', 'getEditedEntityRecord', 'setDrawerActiveView', 'setHeaderActiveView', 'setHideFooterNav', 'setIsFooterNavAllowed', 'setIsHeaderEnabled', 'setIsHeaderNavigationEnabled', and 'setSidebarActiveView'. Either include them or remove the dependency array

const resetSiteLogo = () => {
const currentDataCopy = { ...currentData };
Expand Down Expand Up @@ -134,11 +134,12 @@
if ( siteLogo ) {
trackOnboardingEvent(
new OnboardingEvent(
ACTION_LOGO_ADDED
),
{
source: SITEGEN_FLOW,
}
ACTION_LOGO_ADDED,
undefined,
{
source: SITEGEN_FLOW,
}
)
);
}
} }
Expand Down
Loading