-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Fork A/B Test Winner #548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change Events::get_category()[0]
to Events::get_category()
and make the latter a string like before in includes/RestApi/EventsController.php
?
Considering we might need to have an array in the long term as more keys could be there ( wonder-start, experiment ), due to this I left the code in place, as other's might not be aware of this little change. |
If you're not comfortable with removing it, you could write a validation callback that validates against the entire array instead of just the 0th element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA done. Looks good!
Proposed changes
Type of Change
Checklist
Changelog