Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Fork A/B Test Winner #548

Merged
merged 5 commits into from
May 2, 2024
Merged

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Apr 23, 2024

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Changelog

Screenshot 2024-04-24 at 9 10 25 AM

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Apr 23, 2024
@officiallygod officiallygod self-assigned this Apr 23, 2024
@officiallygod officiallygod added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Apr 25, 2024
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change Events::get_category()[0] to Events::get_category() and make the latter a string like before in includes/RestApi/EventsController.php?

@officiallygod
Copy link
Member Author

Should we change Events::get_category()[0] to Events::get_category() and make the latter a string like before in includes/RestApi/EventsController.php?

Considering we might need to have an array in the long term as more keys could be there ( wonder-start, experiment ), due to this I left the code in place, as other's might not be aware of this little change.

@arunshenoy99
Copy link
Member

Should we change Events::get_category()[0] to Events::get_category() and make the latter a string like before in includes/RestApi/EventsController.php?

Considering we might need to have an array in the long term as more keys could be there ( wonder-start, experiment ), due to this I left the code in place, as other's might not be aware of this little change.

If you're not comfortable with removing it, you could write a validation callback that validates against the entire array instead of just the 0th element.

@arunshenoy99 arunshenoy99 added QA This PR is in QA and removed Code Review The PR is in Code Review labels May 2, 2024
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA done. Looks good!

@arunshenoy99 arunshenoy99 added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels May 2, 2024
@arunshenoy99 arunshenoy99 merged commit 39138e7 into trunk May 2, 2024
3 of 4 checks passed
@arunshenoy99 arunshenoy99 deleted the enhance/remove-AB-test-PRESS0-999 branch May 2, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants