Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing failures and enabling skipped tests #545

Merged
merged 18 commits into from
May 2, 2024
Merged

fixing failures and enabling skipped tests #545

merged 18 commits into from
May 2, 2024

Conversation

sangeetha-nayak
Copy link
Contributor

@sangeetha-nayak sangeetha-nayak commented Apr 17, 2024 •
edited
Loading

Proposed changes

Fixed site-detail step tests. Disabled frequently failing tests on Preview, Site-logo and Editor steps

Type of Change

  • Test fix/ Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Apr 19, 2024
@sangeetha-nayak sangeetha-nayak added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. Do not merge labels Apr 22, 2024
@sangeetha-nayak sangeetha-nayak added WIP PR is a Work in Progress and not ready for review. and removed Code Review The PR is in Code Review labels Apr 25, 2024
@sangeetha-nayak sangeetha-nayak removed the request for review from officiallygod April 25, 2024 05:52
@sangeetha-nayak sangeetha-nayak requested review from officiallygod and removed request for officiallygod April 29, 2024 13:50
officiallygod
officiallygod reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks fine.

tests/cypress/integration/5-AI-SiteGen-onboarding-flow/4-site-logo.cy.js Show resolved Hide resolved
tests/cypress/integration/5-AI-SiteGen-onboarding-flow/4-site-logo.cy.js Show resolved Hide resolved
@sangeetha-nayak sangeetha-nayak added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Apr 30, 2024
officiallygod
officiallygod approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sangeetha-nayak sangeetha-nayak merged commit 8004f63 into trunk May 2, 2024
4 of 5 checks passed
@sangeetha-nayak sangeetha-nayak deleted the fix-skipped-test branch May 2, 2024 04:27
@wpalani wpalani mentioned this pull request May 15, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

Assignees
No one assigned
Labels
Code Review The PR is in Code Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sangeetha-nayak @officiallygod