Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed url to wpsiteurl in mini-preview instead of dummy domain #538

Merged
merged 3 commits into from
May 2, 2024
Merged

changed url to wpsiteurl in mini-preview instead of dummy domain #538

merged 3 commits into from
May 2, 2024

Conversation

ajayadav09
Copy link
Contributor

@ajayadav09 ajayadav09 commented Apr 10, 2024 •
edited
Loading

Proposed changes

Screenshot 2024-04-10 at 7 27 57 PM

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 added the Code Review The PR is in Code Review label Apr 12, 2024
@ajayadav09 ajayadav09 requested review from officiallygod and removed request for officiallygod April 30, 2024 12:16
@arunshenoy99 arunshenoy99 added QA This PR is in QA Ready to merge The Code Review and QA is done and it can be merged. and removed Code Review The PR is in Code Review QA This PR is in QA labels May 2, 2024
arunshenoy99
arunshenoy99 reviewed May 2, 2024
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA done. Looks good.

@arunshenoy99 arunshenoy99 merged commit e233877 into trunk May 2, 2024
3 of 5 checks passed
@arunshenoy99 arunshenoy99 deleted the PRESS0-879-dummy-domain branch May 2, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees
No one assigned
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajayadav09 @arunshenoy99