Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DIY theme change modal showing up in Sitegen Flow #537

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Fix DIY theme change modal showing up in Sitegen Flow #537

merged 4 commits into from
Apr 9, 2024

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Apr 9, 2024 •
edited
Loading

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

The BUG

image

@officiallygod officiallygod added the Code Review The PR is in Code Review label Apr 9, 2024
@officiallygod officiallygod self-assigned this Apr 9, 2024
@officiallygod officiallygod changed the title Fix DIY theme change loader showing up in Sitegen Flow Fix DIY theme change modal showing up in Sitegen Flow Apr 9, 2024
@officiallygod officiallygod changed the base branch from trunk to release/2.1.9 April 9, 2024 08:14
@arunshenoy99 arunshenoy99 merged commit 8f3fb29 into release/2.1.9 Apr 9, 2024
1 check passed
@arunshenoy99 arunshenoy99 deleted the hotfix/Old-DIY-loader-showing-new-Sitegen-AI-bug branch April 9, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees

@officiallygod officiallygod

Labels
Code Review The PR is in Code Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@officiallygod @arunshenoy99