-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Character count in Site Details #521
Conversation
Looks good. Although from the UX POV, when the 'characters left' count reaches 0. It might confuse the users into believing that anything that they type beyond this might not be considered. or we can change the copy to say something like, 'Minimum characters required'. |
Makes sense, let me bring this up, Thanks. |
Or we can simply replace text with some icon, like checkmark or thumbs up |
Removed the count itself on completion of 200 character count, Thanks. |
src/OnboardingSPA/components/TextInput/TextInputSiteGen/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/components/TextInput/TextInputSiteGen/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/components/TextInput/TextInputSiteGen/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks! @officiallygod
Proposed changes
This PR adds a character count inside the site details screen according to the user input.
Type of Change
Checklist
Further comments
Screenshots: