Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character count in Site Details #521

Merged
merged 12 commits into from
Apr 8, 2024
Merged

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Mar 14, 2024

Proposed changes

This PR adds a character count inside the site details screen according to the user input.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Screenshots:

Screenshot 2024-04-03 at 12 17 29 PM Screenshot 2024-04-05 at 12 01 15 PM

@officiallygod officiallygod added the Code Review The PR is in Code Review label Mar 14, 2024
@officiallygod officiallygod self-assigned this Mar 14, 2024
@officiallygod officiallygod added WIP PR is a Work in Progress and not ready for review. and removed Code Review The PR is in Code Review labels Mar 14, 2024
@officiallygod officiallygod added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Apr 3, 2024
@officiallygod officiallygod added QA This PR is in QA and removed Code Review The PR is in Code Review labels Apr 5, 2024
@ajayadav09
Copy link
Contributor

Looks good. Although from the UX POV, when the 'characters left' count reaches 0. It might confuse the users into believing that anything that they type beyond this might not be considered. or we can change the copy to say something like, 'Minimum characters required'.

@officiallygod
Copy link
Member Author

Looks good. Although from the UX POV, when the 'characters left' count reaches 0. It might confuse the users into believing that anything that they type beyond this might not be considered. or we can change the copy to say something like, 'Minimum characters required'.

Makes sense, let me bring this up, Thanks.

@girish-lokapure
Copy link
Contributor

Looks good. Although from the UX POV, when the 'characters left' count reaches 0. It might confuse the users into believing that anything that they type beyond this might not be considered. or we can change the copy to say something like, 'Minimum characters required'.

Or we can simply replace text with some icon, like checkmark or thumbs up

@officiallygod
Copy link
Member Author

Looks good. Although from the UX POV, when the 'characters left' count reaches 0. It might confuse the users into believing that anything that they type beyond this might not be considered. or we can change the copy to say something like, 'Minimum characters required'.

Removed the count itself on completion of 200 character count, Thanks.

Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks! @officiallygod

@arunshenoy99 arunshenoy99 added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Apr 8, 2024
@arunshenoy99 arunshenoy99 merged commit 0854eb5 into trunk Apr 8, 2024
2 of 5 checks passed
@arunshenoy99 arunshenoy99 deleted the add/word-count-in-details branch April 8, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants